Wire BPHX channel pressure drop on both sides with selectable correlations.
Some checks failed
CI / check (push) Has been cancelled
Some checks failed
CI / check (push) Has been cancelled
Replace isobaric 4-port closures with SimplifiedChannel (default) and Martin1996 DP models so z_dp and UI dp_correlation actually affect the Newton solve. Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
@@ -206,8 +206,14 @@ describe("COMPONENTS catalogue integrity", () => {
|
||||
"channel_spacing_mm",
|
||||
"chevron_angle_deg",
|
||||
"correlation",
|
||||
"dp_correlation",
|
||||
]),
|
||||
);
|
||||
const dp = COMPONENT_BY_TYPE[type].params.find((p) => p.key === "dp_correlation");
|
||||
expect(dp?.options?.map((o) => o.value)).toEqual([
|
||||
"SimplifiedChannel",
|
||||
"Martin1996",
|
||||
]);
|
||||
}
|
||||
});
|
||||
|
||||
|
||||
@@ -1076,6 +1076,19 @@ export const COMPONENTS: ComponentMeta[] = [
|
||||
{ value: "Shah2021", label: "Shah 2021" },
|
||||
],
|
||||
},
|
||||
{
|
||||
key: "dp_correlation",
|
||||
label: "Pressure-drop correlation",
|
||||
kind: "string",
|
||||
default: "SimplifiedChannel",
|
||||
section: "Pressure drop",
|
||||
description:
|
||||
"Channel friction on both hot and cold sides (independent of HTC). Default SimplifiedChannel; Martin1996 uses chevron angle.",
|
||||
options: [
|
||||
{ value: "SimplifiedChannel", label: "Simplified channel (default)" },
|
||||
{ value: "Martin1996", label: "Martin 1996 (chevron)" },
|
||||
],
|
||||
},
|
||||
{ key: "ua", label: "UA override", kind: "number", unit: "W/K", section: "Calibration", min: 0.0, advanced: true },
|
||||
{
|
||||
key: "calib_sst_c",
|
||||
@@ -1163,6 +1176,19 @@ export const COMPONENTS: ComponentMeta[] = [
|
||||
{ value: "Shah2021", label: "Shah 2021" },
|
||||
],
|
||||
},
|
||||
{
|
||||
key: "dp_correlation",
|
||||
label: "Pressure-drop correlation",
|
||||
kind: "string",
|
||||
default: "SimplifiedChannel",
|
||||
section: "Pressure drop",
|
||||
description:
|
||||
"Channel friction on both hot and cold sides (independent of HTC). Default SimplifiedChannel; Martin1996 uses chevron angle.",
|
||||
options: [
|
||||
{ value: "SimplifiedChannel", label: "Simplified channel (default)" },
|
||||
{ value: "Martin1996", label: "Martin 1996 (chevron)" },
|
||||
],
|
||||
},
|
||||
{ key: "ua", label: "UA override", kind: "number", unit: "W/K", section: "Calibration", min: 0.0, advanced: true },
|
||||
{
|
||||
key: "calib_sdt_c",
|
||||
|
||||
@@ -141,6 +141,7 @@ const PARAM_ALIASES: Record<string, string[]> = {
|
||||
rh: ["relative_humidity"],
|
||||
p_set_bar: ["pressure_bar"],
|
||||
p_back_bar: ["pressure_bar"],
|
||||
dp_correlation: ["DpCorrelation", "dpCorrelation"],
|
||||
};
|
||||
|
||||
function getParam(
|
||||
|
||||
Reference in New Issue
Block a user