Snapshot WIP: solver HP epic progress, BPHX/HX physics, BMAD skill refresh.
Some checks failed
CI / check (push) Has been cancelled
Some checks failed
CI / check (push) Has been cancelled
Capture uncommitted solver robustness work (regularization, domain errors, linear solver lifecycle, tube DP/MSH), web workbench updates, and synced BMAD skills across IDE agent folders before starting BPHX pressure-drop. Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
@@ -9,7 +9,7 @@ depends_on: 0-1-jacobian-killing-pattern-audit-fd-test-harness
|
||||
|
||||
# Story 0.2: Phantom-Gradient Regularization Standard
|
||||
|
||||
Status: review
|
||||
Status: done
|
||||
|
||||
<!-- Note: Validation is optional. Run validate-create-story for quality check before dev-story. -->
|
||||
<!-- Ultimate context engine analysis completed - comprehensive developer guide created -->
|
||||
@@ -98,6 +98,19 @@ so that fixes are uniform and derivative-safe instead of ad-hoc.
|
||||
- [x] 6.2 `cargo test -p entropyk-components` green — proves no accidental physics regressions from doc-only / non-touch policy.
|
||||
- [x] 6.3 Diff review: production component residual files should show **zero** physics diffs attributable to this story.
|
||||
|
||||
### Review Findings
|
||||
|
||||
- [x] [Review][Patch] smooth_clamp overlapping bounds validation [crates/core/src/smoothing.rs:458]
|
||||
- [x] [Review][Patch] normalize panic on NaN inputs [crates/core/src/smoothing.rs:69]
|
||||
- [x] [Review][Patch] smooth_clamp panic on NaN inputs [crates/core/src/smoothing.rs:458]
|
||||
- [x] [Review][Patch] smooth_max_derivative and smooth_min_derivative NaN division [crates/core/src/smoothing.rs:310]
|
||||
- [x] [Review][Patch] smooth_abs_derivative NaN division and overflow handling [crates/core/src/smoothing.rs:418]
|
||||
- [x] [Review][Patch] NaN propagation in derivatives under degenerate/fallback paths [crates/core/src/smoothing.rs:310]
|
||||
- [x] [Review][Defer] smooth_max and smooth_min overflow for extremely large inputs [crates/core/src/smoothing.rs:293] — deferred, pre-existing
|
||||
- [x] [Review][Defer] smooth_abs overflow for extremely large inputs [crates/core/src/smoothing.rs:396] — deferred, pre-existing
|
||||
- [x] [Review][Defer] slope amplification for very small widths in step derivatives [crates/core/src/smoothing.rs:123] — deferred, pre-existing
|
||||
- [x] [Review][Defer] cubic_blend and quintic_blend bound swapping [crates/core/src/smoothing.rs:205] — deferred, pre-existing
|
||||
|
||||
## Dev Notes
|
||||
|
||||
### Context & Positioning
|
||||
|
||||
Reference in New Issue
Block a user