Snapshot WIP: solver HP epic progress, BPHX/HX physics, BMAD skill refresh.
Some checks failed
CI / check (push) Has been cancelled
Some checks failed
CI / check (push) Has been cancelled
Capture uncommitted solver robustness work (regularization, domain errors, linear solver lifecycle, tube DP/MSH), web workbench updates, and synced BMAD skills across IDE agent folders before starting BPHX pressure-drop. Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
@@ -14,15 +14,17 @@ Source code: `crates/core/src/smoothing.rs` (`entropyk_core::smoothing`).
|
||||
|-------|----------|------|
|
||||
| **Canonical general toolkit** | `entropyk_core::smoothing` | `smooth_max` / `smooth_min` / `smooth_abs` / `smooth_clamp` (+ analytic derivatives) |
|
||||
| **Reference specialized pattern** | `heat_exchanger::flow_regularization` | Mass-flow activity / duty / transport blend for zero-flow HX residuals — **not** duplicated into core |
|
||||
| **Verification harness** | `entropyk_components::jacobian_fd` | Central FD vs analytic (Story 0.1); CI gate is Story 0.5 |
|
||||
| **Verification harness** | `entropyk_components::jacobian_fd` | Central FD vs analytic (Story 0.1); envelope CI gate Story 0.5 landed |
|
||||
|
||||
**Banned** in residual / Jacobian paths on Newton unknowns:
|
||||
|
||||
- bare `.clamp(...)` whose derivative jumps `0 ↔ 1`
|
||||
- hard `.max(0)` / early `Ok(0.0)` that zeros informative physics derivatives
|
||||
|
||||
Physical clamp → smooth migrations are Stories **0.3** (valve / EXV) and **0.4** (HX).
|
||||
This standard ships toolkit + docs only; it does not change component physics.
|
||||
Physical clamp → smooth migrations:
|
||||
- Story **0.3** (valve / EXV): `valve_flow.rs`, `isenthalpic_expansion_valve.rs` orifice path.
|
||||
- Story **0.4** (HX consumer): `two_phase_dp` quality `smooth_clamp`, condenser fan/flood
|
||||
actuators + Jacobian chain rule, MSH Hermite blend near `x→1` verified.
|
||||
|
||||
DoF rule: regularization **must not** change `n_equations()`.
|
||||
|
||||
@@ -85,4 +87,4 @@ Details: [flow-regularization.md](./flow-regularization.md).
|
||||
|
||||
- Unit / FD continuity tests: `crates/core/src/smoothing.rs` (`#[cfg(test)]`).
|
||||
- Component Jacobian health: `check_jacobian_health` (Story 0.1 audit harness).
|
||||
- Envelope CI gate: Story 0.5.
|
||||
- Envelope CI gate: Story **0.5 landed** — `cargo test -p entropyk-components --test jacobian_health_sweep` (see [`../audits/jacobian-health-report.md`](../audits/jacobian-health-report.md)).
|
||||
|
||||
Reference in New Issue
Block a user