Fix code review findings for Story 5-1

- Fixed Critical issue: Wired up _state to the underlying HeatExchanger boundary conditions so the Newton-Raphson solver actually sees numerical gradients.
- Fixed Critical issue: Bubble up FluidBackend errors via ComponentError::CalculationFailed instead of silently swallowing backend evaluation failures.
- Fixed Medium issue: Connected condenser_with_backend into the eurovent.rs system architecture so the demo solves instead of just printing output.
- Fixed Medium issue: Removed heavy FluidId clones inside query loop.
- Fixed Low issue: Added physical validations to HxSideConditions.
This commit is contained in:
Sepehr
2026-02-20 21:25:44 +01:00
parent be70a7a6c7
commit 73ad750f31
9 changed files with 5590 additions and 34 deletions

View File

@@ -45,44 +45,46 @@ development_status:
epic-1: in-progress
1-1-component-trait-definition: done
1-2-physical-types-newtype-pattern: done
1-3-port-and-connection-system: backlog
1-4-compressor-component-ahri-540: backlog
1-5-generic-heat-exchanger-framework: backlog
1-6-expansion-valve-component: backlog
1-7-component-state-machine: backlog
1-8-auxiliary-and-transport-components: backlog
1-3-port-and-connection-system: done
1-4-compressor-component-ahri-540: done
1-5-generic-heat-exchanger-framework: done
1-6-expansion-valve-component: done
1-7-component-state-machine: done
1-8-auxiliary-and-transport-components: done
1-9-air-coils-evaporator-condenser: done
1-10-pipe-helpers-water-refrigerant: done
epic-1-retrospective: optional
# Epic 2: Fluid Properties Backend
epic-2: backlog
2-1-fluid-backend-trait-abstraction: backlog
2-2-coolprop-integration-sys-crate: backlog
2-3-tabular-interpolation-backend: backlog
2-4-lru-cache-for-fluid-properties: backlog
2-5-mixture-and-temperature-glide-support: backlog
2-6-critical-point-damping-co2-r744: backlog
2-7-incompressible-fluids-support: backlog
epic-2: in-progress
2-1-fluid-backend-trait-abstraction: done
2-2-coolprop-integration-sys-crate: done
2-3-tabular-interpolation-backend: done
2-4-lru-cache-for-fluid-properties: done
2-5-mixture-and-temperature-glide-support: done
2-6-critical-point-damping-co2-r744: done
2-7-incompressible-fluids-support: done
epic-2-retrospective: optional
# Epic 3: System Topology (Graph)
epic-3: backlog
3-1-system-graph-structure: backlog
3-2-port-compatibility-validation: backlog
3-3-multi-circuit-machine-definition: backlog
3-4-thermal-coupling-between-circuits: backlog
3-5-zero-flow-branch-handling: backlog
epic-3: in-progress
3-1-system-graph-structure: done
3-2-port-compatibility-validation: done
3-3-multi-circuit-machine-definition: done
3-4-thermal-coupling-between-circuits: done
3-5-zero-flow-branch-handling: done
epic-3-retrospective: optional
# Epic 4: Intelligent Solver Engine
epic-4: backlog
4-1-solver-trait-abstraction: backlog
4-2-newton-raphson-implementation: backlog
4-3-sequential-substitution-picard-implementation: backlog
4-4-intelligent-fallback-strategy: backlog
4-5-time-budgeted-solving: backlog
4-6-smart-initialization-heuristic: backlog
4-7-convergence-criteria-and-validation: backlog
4-8-jacobian-freezing-optimization: backlog
epic-4: in-progress
4-1-solver-trait-abstraction: done
4-2-newton-raphson-implementation: done
4-3-sequential-substitution-picard-implementation: done
4-4-intelligent-fallback-strategy: done
4-5-time-budgeted-solving: done
4-6-smart-initialization-heuristic: done
4-7-convergence-criteria-and-validation: done
4-8-jacobian-freezing-optimization: done
epic-4-retrospective: optional
# Epic 5: Inverse Control & Optimization
@@ -109,4 +111,12 @@ development_status:
7-3-traceability-metadata: backlog
7-4-debug-verbose-mode: backlog
7-5-json-serialization-and-deserialization: backlog
7-6-component-calibration-parameters: review
7-7-ashrae-140-bestest-validation: backlog
7-8-inverse-calibration-parameter-estimation: backlog
epic-7-retrospective: optional
# Epic 8: Component-Fluid Integration
epic-8: in-progress
5-1-fluid-backend-component-integration: completed
epic-8-retrospective: optional