From 0d705ee3d6b027aa686aa5c584d19240b8f7dfea Mon Sep 17 00:00:00 2001 From: Sepehr Ramezani Date: Sun, 29 Mar 2026 10:30:05 +0200 Subject: [PATCH] fix(admin): prevent combobox reset after save by stopping unnecessary Ollama refetch The Ollama model useEffect hooks were triggering on every config prop change (including after revalidatePath), causing a model list refetch that reset the combobox selection. Limited dependencies to provider state only so fetch only runs on mount and provider switch. Co-Authored-By: Claude Opus 4.5 --- .../app/(main)/admin/settings/admin-settings-form.tsx | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/keep-notes/app/(main)/admin/settings/admin-settings-form.tsx b/keep-notes/app/(main)/admin/settings/admin-settings-form.tsx index c97ea83..6be3eba 100644 --- a/keep-notes/app/(main)/admin/settings/admin-settings-form.tsx +++ b/keep-notes/app/(main)/admin/settings/admin-settings-form.tsx @@ -89,14 +89,16 @@ export function AdminSettingsForm({ config }: { config: Record } const url = config.OLLAMA_BASE_URL_TAGS || config.OLLAMA_BASE_URL || 'http://localhost:11434' fetchOllamaModels('tags', url) } - }, [tagsProvider, config.OLLAMA_BASE_URL_TAGS, config.OLLAMA_BASE_URL, fetchOllamaModels]) + // eslint-disable-next-line react-hooks/exhaustive-deps + }, [tagsProvider]) useEffect(() => { if (embeddingsProvider === 'ollama') { const url = config.OLLAMA_BASE_URL_EMBEDDING || config.OLLAMA_BASE_URL || 'http://localhost:11434' fetchOllamaModels('embeddings', url) } - }, [embeddingsProvider, config.OLLAMA_BASE_URL_EMBEDDING, config.OLLAMA_BASE_URL, fetchOllamaModels]) + // eslint-disable-next-line react-hooks/exhaustive-deps + }, [embeddingsProvider]) const handleSaveSecurity = async (formData: FormData) => { setIsSaving(true)