refactor(ux): consolidate BMAD skills, update design system, and clean up Prisma generated client

keep-notes/lib/ai/services/semantic-search.service.ts

@@ -22,6 +22,7 @@ export interface SearchOptions {
   threshold?: number // Minimum similarity score (0-1)
   includeExactMatches?: boolean
   notebookId?: string // NEW: Filter by notebook for contextual search (IA5)
+  defaultTitle?: string // Optional default title for untitled notes (i18n)
 }
 
 export class SemanticSearchService {
@@ -40,7 +41,8 @@ export class SemanticSearchService {
       limit = this.DEFAULT_LIMIT,
       threshold = this.DEFAULT_THRESHOLD,
       includeExactMatches = true,
-      notebookId // NEW: Contextual search within notebook (IA5)
+      notebookId, // NEW: Contextual search within notebook (IA5)
+      defaultTitle = 'Untitled' // Default title for i18n
     } = options
 
     if (!query || query.trim().length < 2) {
@@ -63,14 +65,15 @@ export class SemanticSearchService {
         semanticResults
       )
 
-      // 4. Sort by final score and limit
-      return fusedResults
-        .sort((a, b) => b.score - a.score)
-        .slice(0, limit)
-        .map(result => ({
-          ...result,
-          matchType: result.score > 0.8 ? 'exact' : 'related'
-        }))
+    // 4. Sort by final score and limit
+    return fusedResults
+      .sort((a, b) => b.score - a.score)
+      .slice(0, limit)
+      .map(result => ({
+        ...result,
+        title: result.title || defaultTitle,
+        matchType: result.score > 0.8 ? 'exact' : 'related'
+      }))
     } catch (error) {
       console.error('Error in hybrid search:', error)
       // Fallback to keyword-only search
@@ -79,7 +82,7 @@ export class SemanticSearchService {
       // Fetch note details for keyword results
       const noteIds = keywordResults.slice(0, limit).map(r => r.noteId)
       const notes = await prisma.note.findMany({
-        where: { id: { in: noteIds } },
+        where: { id: { in: noteIds }, trashedAt: null },
         select: {
           id: true,
           title: true,
@@ -90,7 +93,7 @@ export class SemanticSearchService {
 
       return notes.map(note => ({
         noteId: note.id,
-        title: note.title,
+        title: note.title || defaultTitle,
         content: note.content,
         score: 1.0, // Default score for keyword-only results
         matchType: 'related' as const,
@@ -107,17 +110,27 @@ export class SemanticSearchService {
     userId: string | null,
     notebookId?: string // NEW: Filter by notebook (IA5)
   ): Promise<Array<{ noteId: string; rank: number }>> {
-    // Build query for case-insensitive search
-    const searchPattern = `%${query}%`
+    // Extract keywords (words with > 3 characters) to avoid entire sentence matching failing
+    const stopWords = new Set(['comment', 'pourquoi', 'lequel', 'laquelle', 'avec', 'pour', 'dans', 'sur', 'est-ce']);
+    const keywords = query.toLowerCase()
+      .split(/[^a-z0-9àáâäçéèêëíìîïñóòôöúùûü]/i)
+      .filter(w => w.length > 3 && !stopWords.has(w));
+      
+    // If no good keywords found, fallback to the original query but it'll likely fail
+    const searchTerms = keywords.length > 0 ? keywords : [query];
+
+    // Build Prisma OR clauses for each keyword
+    const searchConditions = searchTerms.flatMap(term => [
+      { title: { contains: term } },
+      { content: { contains: term } }
+    ]);
 
     const notes = await prisma.note.findMany({
       where: {
         ...(userId ? { userId } : {}),
         ...(notebookId !== undefined ? { notebookId } : {}), // NEW: Notebook filter
-        OR: [
-          { title: { contains: query } },
-          { content: { contains: query } }
-        ]
+        trashedAt: null,
+        OR: searchConditions
       },
       select: {
         id: true,
@@ -178,6 +191,7 @@ export class SemanticSearchService {
         where: {
           ...(userId ? { userId } : {}),
           ...(notebookId !== undefined ? { notebookId } : {}),
+          trashedAt: null,
           noteEmbedding: { isNot: null }
         },
         select: {
@@ -245,7 +259,7 @@ export class SemanticSearchService {
     // Fetch note details
     const noteIds = Array.from(scores.keys())
     const notes = await prisma.note.findMany({
-      where: { id: { in: noteIds } },
+      where: { id: { in: noteIds }, trashedAt: null },
       select: {
         id: true,
         title: true,
@@ -313,6 +327,46 @@ export class SemanticSearchService {
     }
   }
 
+  /**
+   * Search as a specific user (no auth() call).
+   * Used by agent tools that run server-side without HTTP session.
+   */
+  async searchAsUser(
+    userId: string,
+    query: string,
+    options: SearchOptions = {}
+  ): Promise<SearchResult[]> {
+    const {
+      limit = this.DEFAULT_LIMIT,
+      threshold = this.DEFAULT_THRESHOLD,
+      includeExactMatches = true,
+      notebookId,
+      defaultTitle = 'Untitled'
+    } = options
+
+    if (!query || query.trim().length < 2) {
+      return []
+    }
+
+    try {
+      const keywordResults = await this.keywordSearch(query, userId, notebookId)
+      const semanticResults = await this.semanticVectorSearch(query, userId, threshold, notebookId)
+      const fusedResults = await this.reciprocalRankFusion(keywordResults, semanticResults)
+
+      return fusedResults
+        .sort((a, b) => b.score - a.score)
+        .slice(0, limit)
+        .map(result => ({
+          ...result,
+          title: result.title || defaultTitle,
+          matchType: result.score > 0.8 ? 'exact' : 'related'
+        }))
+    } catch (error) {
+      console.error('Error in searchAsUser:', error)
+      return []
+    }
+  }
+
   /**
    * Batch index multiple notes (for initial migration or bulk updates)
    */