sepehr/Keep
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(perf): remove redundant router.refresh() calls from note-card.tsx

Browse Source 
Remove 5 unnecessary router.refresh() calls in optimistic update handlers
(togglePin, toggleArchive, handleColorChange, handleCheckItem, handleRemoveFusedBadge).
These handlers already use addOptimisticNote() for instant UI feedback and
the server actions call revalidatePath('/') for cache invalidation.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Sepehr Ramezani
2026-04-01 21:13:01 +02:00
parent df088510be
commit 8f35bac56f
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
keep-notes/components/note-card.tsx
View File

@@ -233,7 +233,6 @@ export const NoteCard = memo(function NoteCard({
startTransition(async () => { startTransition(async () => {
addOptimisticNote({ isPinned: !note.isPinned }) addOptimisticNote({ isPinned: !note.isPinned })
await togglePin(note.id, !note.isPinned) await togglePin(note.id, !note.isPinned)
router.refresh()
if (!note.isPinned) { if (!note.isPinned) {
toast.success(t('notes.pinned') || 'Note pinned') toast.success(t('notes.pinned') || 'Note pinned')
@@ -247,7 +246,6 @@ export const NoteCard = memo(function NoteCard({
startTransition(async () => { startTransition(async () => {
addOptimisticNote({ isArchived: !note.isArchived }) addOptimisticNote({ isArchived: !note.isArchived })
await toggleArchive(note.id, !note.isArchived) await toggleArchive(note.id, !note.isArchived)
router.refresh()
}) })
} }