sepehr/office_translator
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(glossaries): prevent translation data destruction on language selector change for multi glossaries
All checks were successful
Deploy to Production / Build and Deploy (push) Successful in 2m53s
Details

Browse Source
This commit is contained in:
sepehr
2026-06-28 11:03:31 +02:00
parent de9407f974
commit 36aeac2c5e
1 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
frontend/src/app/dashboard/glossaries/[id]/page.tsx
View File

@@ -153,10 +153,12 @@ export default function GlossaryDetailPage() {
if (i !== index) return t; if (i !== index) return t;
const translations = { ...(t.translations || {}) } as Record<string, string>; const translations = { ...(t.translations || {}) } as Record<string, string>;
const editLang = field === 'source' ? sourceLanguage : targetLanguage; const editLang = (field === 'source' ? sourceLanguage : targetLanguage).toLowerCase();
const srcLang = glossary.source_language.toLowerCase();
const tgtLang = glossary.target_language.toLowerCase();
if (field === 'source') { if (field === 'source') {
if (editLang === glossary.source_language) { if (editLang === srcLang) {
return { ...t, source: value }; return { ...t, source: value };
} else { } else {
if (editLang && editLang !== 'multi') { if (editLang && editLang !== 'multi') {
@@ -165,7 +167,7 @@ export default function GlossaryDetailPage() {
return { ...t, translations }; return { ...t, translations };
} }
} else { } else {
if (editLang === 'multi' || editLang === glossary.target_language) { if (editLang === 'multi' || editLang === tgtLang) {
return { ...t, target: value }; return { ...t, target: value };
} else { } else {
if (editLang && editLang !== 'multi') { if (editLang && editLang !== 'multi') {
@@ -215,12 +217,24 @@ export default function GlossaryDetailPage() {
}; };
const handleSourceLanguageChange = (newLang: string) => { const handleSourceLanguageChange = (newLang: string) => {
// For multilingual glossaries, the selector is a VIEW filter only.
// migrateTerms must not be called — it would destroy translation data.
if (!glossary || glossary.target_language === 'multi') {
setSourceLanguage(newLang);
return;
}
const updated = migrateTerms(terms, sourceLanguage, newLang, targetLanguage, targetLanguage); const updated = migrateTerms(terms, sourceLanguage, newLang, targetLanguage, targetLanguage);
setSourceLanguage(newLang); setSourceLanguage(newLang);
setTerms(updated); setTerms(updated);
}; };
const handleTargetLanguageChange = (newLang: string) => { const handleTargetLanguageChange = (newLang: string) => {
// For multilingual glossaries, the selector is a VIEW filter only.
// migrateTerms must not be called — it would destroy translation data.
if (!glossary || glossary.target_language === 'multi') {
setTargetLanguage(newLang);
return;
}
const updated = migrateTerms(terms, sourceLanguage, sourceLanguage, targetLanguage, newLang); const updated = migrateTerms(terms, sourceLanguage, sourceLanguage, targetLanguage, newLang);
setTargetLanguage(newLang); setTargetLanguage(newLang);
setTerms(updated); setTerms(updated);