sepehr/office_translator
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: don't auto-select glossary when no target language match

Browse Source 
When activating the glossary toggle, only auto-select a glossary if it
matches BOTH source and target language. If no matching glossary exists
(e.g. translating to Persian but only have FR→EN glossaries), leave the
selector empty so the user picks manually instead of forcing an
incompatible glossary.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
sepehr
2026-05-31 22:22:05 +02:00
parent 67b41b2c24
commit ad8ac089a4
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
frontend/src/app/dashboard/translate/GlossarySelector.tsx
View File

@@ -284,10 +284,13 @@ export function GlossarySelector({ sourceLang, targetLang, isPro, mode, glossary
setIsGlossaryEnabled(nextVal); setIsGlossaryEnabled(nextVal);
if (!nextVal) { if (!nextVal) {
onChange(null); onChange(null);
} else if (filteredGlossaries.length > 0 && !glossaryId) { } else if (!glossaryId) {
// Prefer glossary matching target language, fall back to first // Only auto-select if a glossary matches BOTH source and target language
const matching = filteredGlossaries.find(g => g.target_language === targetLang); const matching = filteredGlossaries.find(g => g.target_language === targetLang);
onChange(matching ? matching.id : filteredGlossaries[0].id); if (matching) {
onChange(matching.id);
}
// If no glossary matches the target, leave unselected — user picks manually
} }
}} }}
className={cn( className={cn(